Skip to content

Sign presentation patch#3

Merged
jrhender merged 2 commits intocredentials-apifrom
sign-presentation-patch
Sep 17, 2024
Merged

Sign presentation patch#3
jrhender merged 2 commits intocredentials-apifrom
sign-presentation-patch

Conversation

@jrhender
Copy link

This PR uses pnpm patch to apply a temporary fix to credo to allow DIDAuth presentations to be verified.
This PR:

  • Moves the pnpm config from rush.json to pnpm-config.json as this is required for the rush-pnpm patch-commit command
  • Applied the patch in question, which disables validation for the signed VP if it doesn't have verifiableCredential property.

Needed for rush-pnpm patch-commit to work

Signed-off-by: jrhender <john.henderson@energyweb.org>
Ideally, a permanent upstream fix can be made in Credo.

Signed-off-by: jrhender <john.henderson@energyweb.org>
@jrhender jrhender merged commit 3905a7c into credentials-api Sep 17, 2024
@jrhender jrhender deleted the sign-presentation-patch branch September 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants